Skip to content

chore(skipmaskmanager): remove skip mask files at startup if no frac#427

Merged
forshev merged 2 commits into
mainfrom
426-remove-skip-mask-if-no-frac
Jun 4, 2026
Merged

chore(skipmaskmanager): remove skip mask files at startup if no frac#427
forshev merged 2 commits into
mainfrom
426-remove-skip-mask-if-no-frac

Conversation

@forshev

@forshev forshev commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Description

Now skip mask manager checks at startup whether existing skipmask file has corresponding fraction. If not, skip mask file is removed

Fixes #426


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@codecov-commenter

codecov-commenter commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.65%. Comparing base (dadf267) to head (9be9504).

Files with missing lines Patch % Lines
skipmaskmanager/skip_mask_manager.go 41.17% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
- Coverage   70.70%   70.65%   -0.05%     
==========================================
  Files         219      219              
  Lines       17059    17071      +12     
==========================================
  Hits        12061    12061              
- Misses       4096     4110      +14     
+ Partials      902      900       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eguguchkin eguguchkin requested review from dkharms and eguguchkin May 25, 2026 11:25
Comment thread skipmaskmanager/skip_mask_manager.go Outdated
@eguguchkin eguguchkin added this to the v0.72.0 milestone Jun 2, 2026
@forshev forshev force-pushed the 426-remove-skip-mask-if-no-frac branch from a69a4ef to 9be9504 Compare June 4, 2026 07:40
@forshev forshev merged commit bfd3e53 into main Jun 4, 2026
8 checks passed
@forshev forshev deleted the 426-remove-skip-mask-if-no-frac branch June 4, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip masks GC on startup

4 participants